Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix expected test values when using higher_order #648

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

u3ks
Copy link
Collaborator

@u3ks u3ks commented Jul 18, 2024

No description provided.

@martinfleis
Copy link
Member

I suppose we can wait for libpysal 4.12 and then pin it. That should happen in a few days.

@martinfleis martinfleis changed the title topological nn bug TST: Fix expected test values when suing higher_order Jul 19, 2024
@martinfleis martinfleis changed the title TST: Fix expected test values when suing higher_order TST: Fix expected test values when using higher_order Jul 19, 2024
@martinfleis martinfleis marked this pull request as ready for review July 19, 2024 19:36
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (4037c70) to head (8500bcb).
Report is 88 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #648     +/-   ##
=======================================
+ Coverage   97.4%   98.1%   +0.7%     
=======================================
  Files         26      38     +12     
  Lines       4328    6314   +1986     
=======================================
+ Hits        4214    6191   +1977     
- Misses       114     123      +9     
Files with missing lines Coverage Δ
momepy/functional/tests/test_diversity.py 100.0% <100.0%> (ø)
momepy/weights.py 98.4% <100.0%> (-1.6%) ⬇️

@martinfleis martinfleis merged commit 4e45e54 into pysal:main Jul 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants