Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing #231

Merged
merged 2 commits into from
Nov 5, 2024
Merged

testing #231

merged 2 commits into from
Nov 5, 2024

Conversation

knaaptime
Copy link
Member

@knaaptime knaaptime commented Nov 5, 2024

use xdist

@knaaptime
Copy link
Member Author

@jGaboardi the tests are correct now, but fail when xdist tries to read a file before it exists. We solved this in geosnap using groups, but I don't remember how to assign groups... 🙃

@jGaboardi
Copy link
Member

I think just like the link there for geosnap, no?

@jGaboardi
Copy link
Member

I'll try to take a look later.

@knaaptime
Copy link
Member Author

I think just like the link there for geosnap, no?

well yes, but I cant remember which tests need to go in the same group to avoid the co-read

@knaaptime
Copy link
Member Author

honestly i think the answer is to refactor the tests fairly substantially so that we only need to read the file in once

@jGaboardi
Copy link
Member

We can also create conftest.py and run that get_data() in a pytest_sessionstart(). That will run it once and only once before any tests start.

@knaaptime knaaptime merged commit 72817fb into pysal:main Nov 5, 2024
1 of 6 checks passed
@knaaptime knaaptime deleted the testing branch November 5, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants