Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer loading of importtlib.metadata #466

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

bluetech
Copy link
Member

Refs #445 (comment)

This package is needed for load_setuptools_entrypoints, but it is quite slow to import. While most users do use
load_setuptools_entrypoints, maybe some don't, so let's let them avoid the cost.

For import pluggy:
Before: 36ms
After: 11ms

This package is needed for `load_setuptools_entrypoints`, but it is
quite slow to import. While most users do use
`load_setuptools_entrypoints`, maybe some don't, so let's let them avoid
the cost.

For `import pluggy`:
Before: 36ms
After:  11ms
@ofek
Copy link

ofek commented Dec 26, 2023

Is the failure related to the current change?

@RonnyPfannschmidt
Copy link
Member

we should apply https://hynek.me/articles/ditch-codecov-python/ by grace of @hynek to be free

@bluetech
Copy link
Member Author

We do have if TYPE_CHECKING: in the coverage exclude lines so not I'm sure why it doesn't skip it. Local coverage does skip it.

@bluetech bluetech merged commit 3bdfcac into pytest-dev:main Dec 26, 2023
13 of 17 checks passed
@bluetech bluetech deleted the defer-importlib-metadata branch December 26, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants