Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svnwc: fix regular expression vulnerable to DoS in blame functionality #257

Merged
merged 1 commit into from
Sep 20, 2020
Merged

svnwc: fix regular expression vulnerable to DoS in blame functionality #257

merged 1 commit into from
Sep 20, 2020

Commits on Sep 4, 2020

  1. svnwc: fix regular expression vulnerable to DoS in blame functionality 

    The subpattern `\d+\s*\S+` is ambiguous which makes the pattern subject
to catastrophic backtracing given a string like `"1" * 5000`.

SVN blame output seems to always have at least one space between the
revision number and the user name, so the ambiguity can be fixed by
changing the `*` to `+`.

Fixes pytest-dev#256.
    @bluetech
    bluetech committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    4a9017d View commit details
    Browse the repository at this point in the history