Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with pytest-flake8 #73

Closed
icemac opened this issue Nov 6, 2018 · 0 comments
Closed

Conflict with pytest-flake8 #73

icemac opened this issue Nov 6, 2018 · 0 comments
Assignees
Labels

Comments

@icemac
Copy link
Contributor

icemac commented Nov 6, 2018

When having both pytest-flake8 and pytest-rerunfailures activated I get the following traceback on a flake8 error:

Traceback (most recent call last):
  File ".../eggs/pytest-3.10.0-py2.7.egg/_pytest/main.py", line 185, in wrap_session
    session.exitstatus = doit(config, session) or 0
  File ".../eggs/pytest-3.10.0-py2.7.egg/_pytest/main.py", line 225, in _main
    config.hook.pytest_runtestloop(session=session)
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/hooks.py", line 284, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/manager.py", line 67, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/manager.py", line 61, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/callers.py", line 203, in _multicall
    gen.send(outcome)
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/callers.py", line 81, in get_result
    _reraise(*ex)  # noqa
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File ".../eggs/pytest-3.10.0-py2.7.egg/_pytest/main.py", line 246, in pytest_runtestloop
    item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/hooks.py", line 284, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/manager.py", line 67, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/manager.py", line 61, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/callers.py", line 208, in _multicall
    return outcome.get_result()
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/callers.py", line 81, in get_result
    _reraise(*ex)  # noqa
  File ".../eggs/pluggy-0.8.0-py2.7.egg/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File ".../eggs/pytest_rerunfailures-4.2-py2.7.egg/pytest_rerunfailures.py", line 192, in pytest_runtest_protocol
    _remove_cached_results_from_failed_fixtures(item)
  File ".../eggs/pytest_rerunfailures-4.2-py2.7.egg/pytest_rerunfailures.py", line 130, in _remove_cached_results_from_failed_fixtures
    fixture_info = getattr(item, '_fixtureinfo')
AttributeError: 'Flake8Item' object has no attribute '_fixtureinfo'
@icemac icemac added the bug label Nov 6, 2018
@icemac icemac self-assigned this Nov 6, 2018
icemac pushed a commit that referenced this issue Nov 6, 2018
icemac pushed a commit that referenced this issue Nov 6, 2018
@icemac icemac mentioned this issue Nov 6, 2018
@icemac icemac closed this as completed in #74 Nov 6, 2018
clrpackages pushed a commit to clearlinux-pkgs/pytest-rerunfailures that referenced this issue Nov 7, 2018
…lake8`. (#74)

Michael Howitz (4):
      Fix issue can occur when used together with `pytest-flake8`. (#74)
      Fix ReST and content.
      Make pyroma happy.
      Preparing release 5.0

Steffen Allner (2):
      Back to development: 4.3
      Test with current pytest and Python version. (#70)

5.0 (2018-11-06)
================

- Drop support for pytest versions < 3.6 to reduce the maintenance burden.

- Add support up to pytest version 3.10. Thus supporting the newest 5 pytest
  releases.

- Add support for Python 3.7.

- Fix issue can occur when used together with `pytest-flake8`
  (`#73 <https://github.com/pytest-dev/pytest-rerunfailures/issues/73>`_)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant