Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mark dependency on setuptools #98

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Explicitly mark dependency on setuptools #98

merged 1 commit into from
Nov 18, 2019

Conversation

Eric-Arellano
Copy link
Contributor

pytest-rerunfailures explicitly imports pkg_resources, which is only provided via setuptools:

import pkg_resources

While most Python distributions come bundled with this distribution, not all do and it is more robust to make explicit this dependency in setup.py. Otherwise, if the distribution does not have setuptools already installed, pytest will fail at runtime because it cannot find pkg_resources.

The version is pinned at >=40.0 to match the version used in pytest: https://github.com/pytest-dev/pytest/blob/55a58bcd3d15887610e1303f4076401bd16ba742/setup.py#L22

(P.S. Thanks for this plugin! It's exactly what I need for my project 🎉)

Copy link
Member

@sallner sallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing this PR.

@sallner sallner merged commit e26ef98 into pytest-dev:master Nov 18, 2019
@Eric-Arellano Eric-Arellano deleted the fix-setup-dep branch November 18, 2019 13:53
@sallner
Copy link
Member

sallner commented Nov 18, 2019

@Eric-Arellano I created a new release of the package. https://pypi.org/project/pytest-rerunfailures/8.0/

@Eric-Arellano
Copy link
Contributor Author

Thank you @sallner! I appreciate you merging this and promptly releasing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants