Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10701 - warnings recorder pop match also subclass #11160

Merged
merged 9 commits into from
Jul 4, 2023

Conversation

lesnek
Copy link
Contributor

@lesnek lesnek commented Jul 2, 2023

closes #10701

@lesnek lesnek force-pushed the ml/fix/warinings-recorder-pop branch 7 times, most recently from 9c74aeb to f1e0d59 Compare July 3, 2023 20:57
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - thanks Milan!

changelog/10701.bugfix.rst Outdated Show resolved Hide resolved
testing/test_recwarn.py Outdated Show resolved Hide resolved
src/_pytest/recwarn.py Outdated Show resolved Hide resolved
src/_pytest/recwarn.py Outdated Show resolved Hide resolved
@lesnek lesnek force-pushed the ml/fix/warinings-recorder-pop branch from 5471665 to 5c64d89 Compare July 4, 2023 08:30
testing/test_recwarn.py Outdated Show resolved Hide resolved
src/_pytest/recwarn.py Outdated Show resolved Hide resolved
@lesnek lesnek force-pushed the ml/fix/warinings-recorder-pop branch from 5c64d89 to 72bfabf Compare July 4, 2023 09:24
@lesnek lesnek force-pushed the ml/fix/warinings-recorder-pop branch from 72bfabf to c4876c7 Compare July 4, 2023 09:49
@Zac-HD Zac-HD enabled auto-merge July 4, 2023 17:01
@Zac-HD Zac-HD merged commit d7dbadb into pytest-dev:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WarningsRecorder.pop() improperly matches warning
2 participants