-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement #12231 new flag --xfail-tb #12280
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @okken!
I have left some minor requests, please take a look.
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
for more information, see https://pre-commit.ci
Thanks @nicoddemus. I like all the suggestions. I've accepted all of them. |
Let me know if there's anything else needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
I will let it open for a few more days to give others a chance of reviewing it too. 👍
(Note: we should squash/merge this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@nicoddemus Squash and merge ok now? Or wanna wait a bit more? |
Thanks @okken! |
This implements issue #12231, making xfail tracebacks optional.
Add
--xfail-tb
flag, which turns traceback output for XFAIL results.--xfail-tb
flag is not sent, tracebacks for XFAIL results are NOT shown.--tb
, and can beauto|long|short|line|native|no
.--xfail-tb
set, you won't see them if--tb=no
.Some history:
-rx
/-ra
behavior is identical to pre-8.0 with respect to xfail tracebacks.-rx
or-ra
would not only turn on summary reports for xfail, but also report the tracebacks for xfail results.-rx
, and now we turn on xfail tracebacks with--xfail-tb
.