Exit pytest on collection error (without executing tests) #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, great work! Let's see how the tests turn out... |
Add --continue-on-collection-errors option to restore the previous behaviour:
Execute tests (that were successfully collected) even when collection errors
happen.
Some tests had to be modified e.g. because the return code changed to 2
(EXIT_INTERRUPTED) instead of 1 (EXIT_TESTSFAILED) because an Interrupted
exception is raised on collection error.
Implemented via pair programming with:
Oleg Pidsadnyi <[email protected]>
closes #1421
| @@ -642,3 +642,114 @@ def test___repr__(): | |||
| """) | |||
| reprec = testdir.inline_run("-k repr") | |||
| reprec.assertoutcome(passed=1, failed=0) | |||
|
|
|||
|
|
|||
| COLLECTION_ERROR_PY_FILES = dict( | |||
There was a problem hiding this comment.
Just a tip: sometimes these type of metadata is better put into a session fixture. 😉
|
Tested it on my windows laptop since AppVeyor is stuck (py27,py35,linting). |
This was referenced Aug 24, 2016
This was referenced Aug 31, 2016
This was referenced Nov 15, 2017
Merged
This was referenced Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
master; for new features, targetfeaturesAUTHORSCHANGELOG(choose any open position to avoid merge conflicts with other PRs)