-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Parametrize with fixtures #1660
Proposal: Parametrize with fixtures #1660
Conversation
I think stuff like that should be in a separate subfolder, like |
@The-Compiler done. 👍 |
* This is very inconvenient if you wish to extend an existing test suite by | ||
certain parameters for fixtures that are already used by tests | ||
|
||
pytest version 3.0 and higher reports an error if you try to run above code:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just talk about pytest-3.0, not "higher"
I've added a new entry to the changelog. If you could please thumb this? @hpk42 @The-Compiler 🙇 |
Alternative approach | ||
-------------------- | ||
|
||
A new helper function named ``fixture_request`` tells pytest to yield all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hackebrot after discussing in person with @hpk42, he convinced me the first approach beats this one. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicoddemus can you please comment here, what made you change your mind? 😄 (I am aware it's been a while already 😁 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to remember then, but as you said it has been sometime already. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, let me help you remember. Next beer is on me. 🍻
Please see the Problem section of the added document.
@hpk42 and myself worked on this proposal in the course of the pytest-dev sprint.