-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optparse compatibility - add float and complex #1740
Merged
nicoddemus
merged 3 commits into
pytest-dev:features
from
RonnyPfannschmidt:float-argument
Jul 19, 2016
Merged
optparse compatibility - add float and complex #1740
nicoddemus
merged 3 commits into
pytest-dev:features
from
RonnyPfannschmidt:float-argument
Jul 19, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also documents the implementation quality fixes pytest-dev#457
RonnyPfannschmidt
changed the title
optparse compatibility - add float and complex
optparse compatibility - add float and complex [wip]
Jul 19, 2016
RonnyPfannschmidt
changed the title
optparse compatibility - add float and complex [wip]
optparse compatibility - add float and complex
Jul 19, 2016
@@ -220,6 +220,10 @@ time or change existing behaviors in order to make them less surprising/more use | |||
still present but is now considered deprecated. Thanks to `@RedBeardCode`_ and `@tomviner`_ | |||
for the PR (`#1626`_). | |||
|
|||
* optparse type usage now triggers DeprecationWarnings (`#1740`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add .
to the end of each item here.
Also, I think if you surround "optparse" withou double ` it would read better in the CHANGELOG.
RonnyPfannschmidt
force-pushed
the
float-argument
branch
from
July 19, 2016 18:12
3fe9342
to
9af872a
Compare
Thanks @RonnyPfannschmidt! |
This was referenced Aug 24, 2016
This was referenced Nov 15, 2017
Merged
This was referenced Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also documents the implementation quality
fixes #457