Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention small doc fixes don't need tests/changelog entries in PR template #1988

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Mention small doc fixes don't need tests/changelog entries in PR template #1988

merged 1 commit into from
Oct 5, 2016

Conversation

nicoddemus
Copy link
Member

I think because we have a checklist in place folks might think it necessary to add CHANGELOG entries for simple doc fixes.

@The-Compiler
Copy link
Member

LGTM, feel free to merge after checks pass

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.949% when pulling 10433db on nicoddemus:pr-template-small-fixes into 50b960c on pytest-dev:master.

@The-Compiler
Copy link
Member

Only trial failed (opened #1989 for that), so I'm merging this.

@The-Compiler The-Compiler merged commit 1289cbb into pytest-dev:master Oct 5, 2016
@nicoddemus nicoddemus mentioned this pull request Oct 5, 2016
Merged
@nicoddemus nicoddemus deleted the pr-template-small-fixes branch October 20, 2016 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoddemus @The-Compiler @coveralls