Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSCollector: use session._node_location_to_relpath #6701

Closed
wants to merge 2 commits into from
Closed

FSCollector: use session._node_location_to_relpath #6701

wants to merge 2 commits into from

Commits on Feb 24, 2020

  1. FSCollector: use session._node_location_to_relpath for nodeids 

    This is relevant for `pytest t/foo.py --rootdir=/tmp`.

Before:
```
../../../../tmp F.sxx
…
t/foo.py:5: ValueError
…
FAILED ../../../../tmp/::test_fail - ValueError
```

This removes `_check_initialpaths_for_relpath` (added via
pytest-dev#2776 to address part of the
issue), but it is apparently bad trying to make them relative to any
given arg, when they are meant to be relative to `rootdir` really.
    @blueyed
    blueyed committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    27766e7 View commit details
    Browse the repository at this point in the history

  2. harden test_cmdline_python_namespace_package

    @blueyed
    blueyed committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    bcb2db2 View commit details
    Browse the repository at this point in the history