return non-zero exit code if no tests are collected #817
Conversation
nicoddemus
force-pushed
the
non-collection-exit-error
branch
2 times, most recently
from
308e266
to
4b8b067
Compare
|
All xdist jobs ( Now, why |
nicoddemus
force-pushed
the
non-collection-exit-error
branch
from
4b8b067
to
c722533
Compare
|
looks fine, but we should wait for xdist pr to be merged and released? |
Yes, otherwise |
|
This also fixes #662. |
|
The xdist seems to be merged (even if accidentally). Could somebody give this another shot? |
|
Waiting for a new |
|
@nicoddemus |
nicoddemus
force-pushed
the
non-collection-exit-error
branch
from
44580d5
to
359f248
Compare
|
@RonnyPfannschmidt could you publish |
|
@nicoddemus which index? |
|
Hmm |
|
we should perhaps create a aggregate index to begin with |
|
Perhaps the default for |
|
good point |
nicoddemus
force-pushed
the
non-collection-exit-error
branch
from
e1bfdbf
to
3e41c3c
Compare
|
Weird, I can't reproduce the failures locally... 😞 |
|
those failures are relates to xdist 1.13 - moving boxed into the xdist.boxed plugin broke the code that imported the plugin that way |
|
I couldn't reproduce that on my machine before because those tests are skipped on Windows, as it doesn't have a I fixed the import, and all is green again. |
|
i hope we can have a funeral for boxed as is soonish ^^ |
|
Nice. That would be a pytest-xdist 2.0 then? Also, any other comments before merging this in? |
|
roughly after cache and looponfail land in core, there will be a xdist 2.0 that does only the distributed/multicpu testing |
return non-zero exit code if no tests are collected
|
great job! |
Upstream changes in pytest-dev/pytest#817 make pytest-dist always return EXIT_NOTESTSCOLLECTED because the master node doesn't collect any tests. This patch updates the pytest session about the collected items on the slaves.
Newer versions of pytest exit with status 5 to indicate no tests were collected to run: pytest-dev/pytest#817 Let's take that into account in the run_tests.sh script. Signed-off-by: Sergio Correia <[email protected]>
Newer versions of pytest exit with status 5 to indicate no tests were collected to run: pytest-dev/pytest#817 Let's take that into account in the run_tests.sh script. Signed-off-by: Sergio Correia <[email protected]>
Newer versions of pytest exit with status 5 to indicate no tests were collected to run: pytest-dev/pytest#817 Let's take that into account in the run_tests.sh script. Signed-off-by: Sergio Correia <[email protected]>
Fix #812
Fix #500