Remove upper pinning on tomli #8881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the best practice is to only `<` when you know something is broken, and even then prefer `!=` assuming it will be fixed upstream for maximum compatibility
|
I'm also concerned about using a 27-star library in pytest. |
nicoddemus
approved these changes
Jul 9, 2021
I understand but not sure that's much of a metric, given that TOML itself seems unmaintained, and tomli is gaining traction with other Python projects. |
from the others cited in the issue nothing major has actually adopted this library yet -- we would be the first |
|
I don't feel the same way, but if other maintainers agree, we can revert the PR. |
|
I also adopted it for setuptools_scm and i believe pip also adopts to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the best practice is to only
<when you know something is broken, and even then prefer!=assuming it will be fixed upstream for maximum compatibility