Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require cloudpickle for PyPy #892

Merged
merged 5 commits into from
Dec 29, 2021
Merged

Do not require cloudpickle for PyPy #892

merged 5 commits into from
Dec 29, 2021

Commits on Dec 29, 2021

  1. Do not require cloudpickle for PyPy 

    The cloudpickle package relies on CPython implementation details,
and does not even import on PyPy:

```
ImportError while importing test module '/tmp/attrs/tests/test_3rd_party.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/pypy3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_3rd_party.py:7: in <module>
    import cloudpickle
.tox/pypy3/lib/pypy3.8/site-packages/cloudpickle/__init__.py:4: in <module>
    from cloudpickle.cloudpickle import *  # noqa
.tox/pypy3/lib/pypy3.8/site-packages/cloudpickle/cloudpickle.py:57: in <module>
    from .compat import pickle
.tox/pypy3/lib/pypy3.8/site-packages/cloudpickle/compat.py:13: in <module>
    from _pickle import Pickler  # noqa: F401
E   ModuleNotFoundError: No module named '_pickle'
```

Disable the dependency for PyPy and make the test handle missing
cloudpickle gracefully.
    @mgorny
    mgorny committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    fd48634 View commit details
    Browse the repository at this point in the history

  2. Enable testing on pypy-3.8

    @mgorny
    mgorny committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    d136837 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pypy3-cloudpickle

    @hynek
    hynek authored Dec 29, 2021
    Configuration menu
    Copy the full SHA
    43a3e7b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into pypy3-cloudpickle

    @hynek
    hynek authored Dec 29, 2021
    Configuration menu
    Copy the full SHA
    50cad8d View commit details
    Browse the repository at this point in the history

  5. add a news entry

    @mgorny
    mgorny committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    27a2a4e View commit details
    Browse the repository at this point in the history