structure typing_extension.Literal to support old code #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergaultney
force-pushed
the
master
branch
2 times, most recently
from
96920a1
to
43c3edb
Compare
petergaultney
commented
Dec 9, 2023
Comment on lines
+213
to
+218
| return type in LITERALS or ( | ||
| isinstance( | ||
| type, (_GenericAlias, _LiteralGenericAlias, _SpecialGenericAlias) | ||
| ) | ||
| and type.__origin__ in LITERALS | ||
| ) |
There was a problem hiding this comment.
this is isomorphic to what typing-inspect does and it works in our company's testing as well.
|
LGTM. Just add the links to the PR and issues to the changelog and we're good to go. |
…that still support Python 3.7)
petergaultney
force-pushed
the
master
branch
from
43c3edb
to
70bb8fd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...or libraries that still support Python 3.7
would close #460