-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple pybabel
frontend from distutils/setuptools; remove dependency
#1041
Conversation
80d25a8
to
29be91d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
+ Coverage 89.82% 91.34% +1.52%
==========================================
Files 25 26 +1
Lines 4391 4415 +24
==========================================
+ Hits 3944 4033 +89
+ Misses 447 382 -65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast response. Seems it will be a breaking change for those using the setuptools integration?
@oprypin Could you review this too? :) |
@akx OK hopefully I'll get to it today. If I don't, then let's skip my review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
I have only one big comment about the legacy re-exports
Also checked that MkDocs' setup.py integration (before it was removed) works with this change (also with my suggested edit) |
Co-authored-by: Oleh Prypin <[email protected]>
Fixes #1040