Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve .po IO #1068

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Improve .po IO #1068

merged 2 commits into from
Mar 27, 2024

Conversation

akx
Copy link
Member

@akx akx commented Mar 26, 2024

  • read_po: officially note that it only requires an iterable of strings, not actually a filelike (which is also an iterable of strings)
  • write_po: split-refactor into generate_po() that just yields strings instead of requiring a file

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (40e60a1) to head (51c741c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1068   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files          26       26           
  Lines        4444     4444           
=======================================
  Hits         4044     4044           
  Misses        400      400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx merged commit e0d1018 into master Mar 27, 2024
23 checks passed
@akx akx added this to the Babel 2.15 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants