Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ast.Str with ast.Constant #1083

Merged
merged 1 commit into from
May 13, 2024

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented May 12, 2024

Running the tests under python 3.12 I get deprecation warnings related to the usage of ast.Str which has been deprecated since 3.8 and will be removed in 3.14.

Since 3.8 is also the lowest version supported by babel, we can safely make the change to use ast.Constant everywhere.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (e0d1018) to head (f2fb4cf).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
- Coverage   90.99%   89.84%   -1.16%     
==========================================
  Files          26       26              
  Lines        4444     4451       +7     
==========================================
- Hits         4044     3999      -45     
- Misses        400      452      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@akx akx merged commit 8babd24 into python-babel:master May 13, 2024
22 of 23 checks passed
@tomasr8 tomasr8 deleted the ast-constant branch May 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants