Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Add multi-domain support to compile_catalog command #335

Merged
merged 1 commit into from
Jan 29, 2016
Merged

Frontend: Add multi-domain support to compile_catalog command #335

merged 1 commit into from
Jan 29, 2016

Conversation

ansiwen
Copy link
Contributor

@ansiwen ansiwen commented Jan 27, 2016

Some projects have their translations split up into several text
domains within one package. This change adds the possibility to
specify a space seperated list of domains in the configuration, like
'setup.py compile_catalog --domain="foo bar"', for instance.

@codecov-io
Copy link

Current coverage is 89.41%

Merging #335 into master will increase coverage by +0.01% as of 9db2cf3

@@            master    #335   diff @@
======================================
  Files           23      23       
  Stmts         3736    3740     +4
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3340    3344     +4
  Partial          0       0       
  Missed         396     396       

Review entire Coverage Diff as of 9db2cf3

Powered by Codecov. Updated on successful CI builds.

@ansiwen
Copy link
Contributor Author

ansiwen commented Jan 27, 2016

56% patch coverage? That's not fair, just because I had to indent the whole block? 😒

mo_files.append(self.output_file)
domains = self.domain.split()

for domain in domains:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make for a cleaner patch and cleaner code if you just split def run_domain(self, domain) into a separate fn, I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, good point, will do that

@akx
Copy link
Member

akx commented Jan 28, 2016

@ansiwen Heh, don't worry about codecov's patch measurements. It's a cranky ol' thing sometimes.

Some projects have their translations split up into several text
domains within one package.  This change adds the possibility to
specify a space seperated list of domains in the configuration, like
'setup.py compile_catalog --domain="foo bar"', for instance.
@akx
Copy link
Member

akx commented Jan 29, 2016

Thank you @ansiwen 😻

akx added a commit that referenced this pull request Jan 29, 2016
Frontend: Add multi-domain support to compile_catalog command
@akx akx merged commit 9edb9a0 into python-babel:master Jan 29, 2016
@ansiwen ansiwen deleted the multi_domain branch January 29, 2016 12:07
@ansiwen
Copy link
Contributor Author

ansiwen commented Jan 29, 2016

@akx: Cool, thanks for the merge. When can I expect a release with this feature? (Since we need it for openstack.)

@sils
Copy link
Member

sils commented Jan 29, 2016

@akx as there is demand for a release I'm in favour of doing that soon.

@ansiwen if @akx disagrees we can still do a development release that you can get via pypi if you specify the version exactly in your requirements.txt or install with --pre

@akx
Copy link
Member

akx commented Jan 29, 2016

@ansiwen @sils1297 #330 will need to be implemented before release (it's a seriously short fix).

@ansiwen
Copy link
Contributor Author

ansiwen commented Feb 9, 2016

@sils1297 we will wait for a regular release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants