-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up official support for PyPy 3 #343
Conversation
@akx functionally good, few nitpicks |
Current coverage is
|
24aa71b
to
b7b52e7
Compare
@sils1297 Took another approach here -- instead of strictly checking for versions, only the bit that might fail with unsupported versions (importing In addition, to shorten setup.py a little, I removed the dead documentation building bits. |
With pypy3 advertising itself as py3.2, but still behaving like py3.3, the check started to become awkward. Plus, it seems to be nicer to ask for forgiveness rather than permission.
It's available since Python 2.5, so it's safe for our use.
@sils1297 Re not doing an explicit version check: I looked through some prominent Python libraries and it does seem it's not very common to do a version check like that. (Which, I know, isn't the strongest of arguments...) Anyway, if we see some sort of elevated issue rate due to this change, we can always begin checking for versions more rigidly again. |
Merging as per comments in earlier iterations of PR. |
As suspected in #250, Babel runs fine on PyPy3, it's just that
setup.py
complains. No more!Fixes #250