Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character order and measurement systems #368

Merged
merged 5 commits into from
Apr 5, 2016

Conversation

akx
Copy link
Member

@akx akx commented Mar 19, 2016

This is a fixed version of @alexbodn 's PR #367.

The get_unit_name API from that PR is intentionally excluded; a format_unit API will be included in a subsequent PR.

@codecov-io
Copy link

Current coverage is 89.11%

Merging #368 into master will decrease coverage by -0.64% as of 01c62dc

@@            master    #368   diff @@
======================================
  Files           23      23       
  Stmts         3854    3860     +6
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           3459    3440    -19
  Partial          0       0       
- Missed         395     420    +25

Review entire Coverage Diff as of 01c62dc

Powered by Codecov. Updated on successful CI builds.

@alexbodn
Copy link

thank you very much @akx .
the international web sites developers,
and the pint measurement units project
will enjoy these enhancements the moment you will pull them.

if you could, please tell me when to tell pint people to use upstream instead of my babel.

return self._data['measurement_systems']

@property
def character_order(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have been a great use of a Python 3.4 Enum. Just an observation, no need to do anything here. :)

@akx
Copy link
Member Author

akx commented Mar 30, 2016

Assigned @jtwang for having done initial review on this.

@akx akx force-pushed the char-order-and-measurement-systems branch from e24c15a to f4fae83 Compare March 30, 2016 14:48
@akx akx force-pushed the char-order-and-measurement-systems branch from f4fae83 to 99dc0c7 Compare March 30, 2016 14:56
@akx
Copy link
Member Author

akx commented Mar 30, 2016

Disregard the Codecov fail, btw. I think it's being confused again...

@jtwang
Copy link
Contributor

jtwang commented Apr 5, 2016

@akx - OK to merge! Just the nit about two methods, ignore if you want. ;)

@akx
Copy link
Member Author

akx commented Apr 5, 2016

Nits acknowledged.

@akx akx merged commit 84415b2 into python-babel:master Apr 5, 2016
@akx akx deleted the char-order-and-measurement-systems branch April 5, 2016 20:53
@akx
Copy link
Member Author

akx commented Apr 8, 2016

Gah, this PR shows up in my list of open PRs even if it's merged.

EDIT: Welp, adding this comment fixed the issue.

@pyup-bot pyup-bot mentioned this pull request Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants