Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly speed up date formatting #517

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

akx
Copy link
Member

@akx akx commented Aug 18, 2017

Use * parametrized format patterns in date formatting instead of %%0%...
This is about 60% faster than the old version in a micro-benchmark.

This is about 60% faster than the old version in a micro-benchmark.
@codecov-io
Copy link

codecov-io commented Aug 18, 2017

Codecov Report

Merging #517 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          24       24           
  Lines        4015     4015           
=======================================
  Hits         3621     3621           
  Misses        394      394
Impacted Files Coverage Δ
babel/dates.py 91.24% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653e6d4...8e0e89b. Read the comment docs.

@akx akx merged commit 230e1f7 into python-babel:master Aug 18, 2017
@akx akx deleted the parametrized-format-patterns branch August 18, 2017 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants