Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changes): Fix broken issue links #922

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

DenverCoder1
Copy link
Contributor

Some links in CHANGES.rst are not linking directly to the corresponding issues properly. The extra # sign was causing it to be treated as a url hash on the issue listing page.

image

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #922 (86c5866) into master (a30d7cf) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
- Coverage   91.55%   91.55%   -0.01%     
==========================================
  Files          21       21              
  Lines        4217     4215       -2     
==========================================
- Hits         3861     3859       -2     
  Misses        356      356              
Impacted Files Coverage Δ
babel/messages/catalog.py 95.44% <0.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Should've been more careful distilling the changelog.

Thanks!

@akx akx merged commit d6a3528 into python-babel:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants