Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify datetime imports #945

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Unify datetime imports #945

merged 2 commits into from
Jan 18, 2023

Conversation

akx
Copy link
Member

@akx akx commented Jan 11, 2023

Various modules in Babel imported datetime in various ways, sometimes needing aliases and whatnot; this commit unifies everything to import datetime.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #945 (fd97d5a) into master (14216ed) will decrease coverage by 0.01%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
- Coverage   90.53%   90.52%   -0.01%     
==========================================
  Files          24       24              
  Lines        4395     4392       -3     
==========================================
- Hits         3979     3976       -3     
  Misses        416      416              
Impacted Files Coverage Δ
babel/localtime/__init__.py 62.16% <90.00%> (ø)
babel/dates.py 85.02% <90.90%> (-0.07%) ⬇️
babel/localtime/_unix.py 30.76% <100.00%> (ø)
babel/localtime/_win32.py 62.96% <100.00%> (ø)
babel/messages/catalog.py 95.52% <100.00%> (ø)
babel/messages/frontend.py 87.75% <100.00%> (ø)
babel/numbers.py 98.00% <100.00%> (ø)
babel/support.py 85.09% <100.00%> (ø)
babel/util.py 97.32% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akx akx marked this pull request as ready for review January 11, 2023 11:54
@akx akx added this to the Babel 2.12 milestone Jan 11, 2023
@akx
Copy link
Member Author

akx commented Jan 11, 2023

@DenverCoder1, could you take a reviewy look? :)

Copy link
Contributor

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

babel/support.py Outdated Show resolved Hide resolved
Co-authored-by: Jonah Lawrence <[email protected]>
@akx akx enabled auto-merge (squash) January 18, 2023 08:58
@akx akx merged commit 27380da into master Jan 18, 2023
@akx akx deleted the import-datetime-unify branch December 12, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants