Handle distutils without distutils.msvc9compiler.MSVCCompiler class #118
Conversation
jameshilliard
force-pushed
the
fix-msvccompiler
branch
from
19f50dd
to
5152891
Compare
|
Think someone could look at this and spin a new release? Without this change cffi is broken on Windows with the latest setuptools release. |
jameshilliard
force-pushed
the
fix-msvccompiler
branch
from
5152891
to
547b8f6
Compare
jameshilliard
force-pushed
the
fix-msvccompiler
branch
from
547b8f6
to
06cd38c
Compare
jameshilliard
changed the title
|
I think this will solve the issue being experienced. I don't understand what monkey-patching |
CFFI is currently broken with setuptools 74.0, see python-cffi/cffi#118
|
The patch of |
|
Our guess is that it's related to long-dead versions of the Microsoft toolchain that we have no ability to install/test- we didn't try to evaluate if it was actually useful when we shimmed distutils. The PR looks good to me to get things working again (and this issue is also an excellent illustration of why we should be pinning setuptools upper bounds in our releases- it wouldn't have been possible to break this way). We'll get that merged and kick off a release this week- thanks! |
…118) * Handle distutils without distutils.msvc9compiler.MSVCCompiler class * add explanatory comments --------- Co-authored-by: Matt Davis <[email protected]> (cherry picked from commit 5982be1)
|
I see release 1.17.1 has been made that includes this fix. The Releases section only shows the source code. Has the release been uploaded to pypl.org for pip to find? |
|
Yep, immediately after the release was tagged: https://pypi.org/project/cffi/1.17.1/#files |
|
Not sure if its more fitting to ask in the Pypy tracker, but could you also update the version used by Pypy to use the updated cffi? |
|
That seems pypy/pypy#5027 and is already done by pypy/pypy@87024e9 (And yes it should be asked in the pypy tracker) |
|
Ah of course. Great, thanks! |
|
Seems like we're getting a new failure in python-rtmixer: spatialaudio/python-rtmixer#60 I haven't investigated why, but at least the same build last month worked, and we didn't change any code (though it's always possible the windows-latest image updated or something): https://github.com/spatialaudio/python-rtmixer/actions/runs/10249497029/job/28353006823 |
|
This is because PyPy includes its own copy of cffi, this won't be resolved
until there's a new PyPy release.
…On Mon, Sep 16, 2024 at 11:36 AM Eric Larson ***@***.***> wrote:
Seems like we're getting a new failure in python-rtmixer:
spatialaudio/python-rtmixer#60
<spatialaudio/python-rtmixer#60>
I haven't investigated why, but at least the same build last month worked,
and we didn't change any code (though it's always possible the
windows-latest image updated or something):
https://github.com/spatialaudio/python-rtmixer/actions/runs/10249497029/job/28353006823
—
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBEFCRDLBL5XDJWBTPLZW33H3AVCNFSM6AAAAABNJ2VVXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGI3DCMRRGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
If this runs with a newer version of PyPy than the previous run, then you might need to report that as an issue on the PyPy issue tracker to make sure they are aware that something broke. |
|
pypy/pypy@87024e9
is the fix for pypy, it's just not in a release
…On Mon, Sep 16, 2024 at 2:18 PM Armin Rigo ***@***.***> wrote:
If this runs with a newer version of PyPy than the previous run, then you might need to report that as an issue on the PyPy issue tracker to make sure they are aware that something broke.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Fixes #117.