Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mime type for js is text/plain #181

Closed
mozg4D opened this issue Aug 19, 2019 · 1 comment
Closed

mime type for js is text/plain #181

mozg4D opened this issue Aug 19, 2019 · 1 comment

Comments

@mozg4D
Copy link

mozg4D commented Aug 19, 2019

issue #49 persists)
mime type for *.js files should be "application/javascript"

http://mozg4d.com/images/mime-type.png

eel is amazing) thank you)
@mozg4D
Copy link
Author

mozg4D commented Aug 20, 2019

fixed by adding this to my app):

import mimetypes
mimetypes.add_type('application/javascript', '.js')

@mozg4D mozg4D closed this as completed Aug 20, 2019
aaronsantiago added a commit to aaronsantiago/Eel that referenced this issue May 6, 2020
@aaronsantiago
Set JS mimetype
bcb05c2 
python-eel#49 python-eel#181 it seems like these issues weren't ever truly fixed.

It would be nice if Eel set the mimetypes on its own. According to pallets/flask#1045 this bug will happen for all Windows users.

The most common use for this would be to import JS modules. Chrome doesn't allow modules with incorrect mimetypes to be loaded without a registry edit.

mimetypes is a Python standard lib so there shouldn't be much impact.

Cheers!
@aaronsantiago aaronsantiago mentioned this issue May 6, 2020
Merged
samuelhwilliams pushed a commit that referenced this issue May 24, 2020
@aaronsantiago
Set JS mimetype (#289)
65c1423 
#49 #181 it seems like these issues weren't ever truly fixed.

It would be nice if Eel set the mimetypes on its own. According to pallets/flask#1045 this bug will happen for all Windows users.

The most common use for this would be to import JS modules. Chrome doesn't allow modules with incorrect mimetypes to be loaded without a registry edit.

mimetypes is a Python standard lib so there shouldn't be much impact.

Cheers!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mozg4D