Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German localization for intword missing thousand, and some plurals #88

Closed
NavisGames opened this issue Jan 8, 2023 · 5 comments · Fixed by #89
Closed

German localization for intword missing thousand, and some plurals #88

NavisGames opened this issue Jan 8, 2023 · 5 comments · Fixed by #89
Labels
needs localisation Translations need updating

Comments

@NavisGames
Copy link
Contributor

NavisGames commented Jan 8, 2023

What did you do?

I am using humanize.intword to get a number to be a intword in german.

What did you expect to happen?

The Code should print something like 1.2 Millionen or 2 Tausend

What actually happened?

Everytime, it prints 1.2 Million, on other numbers that are in the thousands it doesnt print "tausend" it prints "thousand" like in the english.

A few Months or Weeks ago everything worked fine in german. i dont know why it doesnt work anymore

What versions are you using?

  • OS: Windows 10
  • Python: 3.10
  • Humanize: 4.40

Please include code that reproduces the issue.

The best reproductions are self-contained scripts with minimal dependencies.

import humanize
_t = humanize.i18n.activate("de_DE")

def intword(num):
    num = humanize.intword(num)
    num = num.replace(".0", "")
    return num

print(intword(1250000) # 1.2 Million should be 1.2 Millionen
print(intword(2000) # 2 thousand should be 2 Tausend
@hugovk
Copy link
Member

hugovk commented Jan 8, 2023

Which version were you using before?

Does it work with 4.3.0 or older?

@NavisGames
Copy link
Contributor Author

i dont excactly remember.. imma install a older version and check out.

@NavisGames
Copy link
Contributor Author

NavisGames commented Jan 8, 2023

i checked, over a million is in german, in million and thousand its in english.
like when it gets to a billion in english, it goes to Milliarde which is correct.

@NavisGames
Copy link
Contributor Author

NavisGames commented Jan 8, 2023

image
with version 4.4.0

in older versions its the same.

@NavisGames
Copy link
Contributor Author

i have made a pull request for the localisation for german :)

@hugovk hugovk changed the title German Localization for Intword doesnt work anymore German localization for intword missing thousand, and some plurals Jan 8, 2023
@hugovk hugovk added the needs localisation Translations need updating label Jan 8, 2023
hugovk added a commit that referenced this issue Jan 8, 2023
@hugovk hugovk closed this as completed in #89 Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs localisation Translations need updating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants