Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create success job for automerge #5

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Create success job for automerge #5

merged 1 commit into from
Apr 14, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 14, 2022

For #3.

Changes proposed in this pull request:

  • This creates a no-op "test successful" job, that only runs when the test matrix is successful
  • Then automerge can have this success job as a required status check in the branch protection rules
  • Means we don't need to tediously add/remove individual matrix entries as they change

image

image

@hugovk hugovk added changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc. labels Apr 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #5 (41bafd4) into main (368fd4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files           9        9           
  Lines         635      635           
=======================================
  Hits          633      633           
  Misses          2        2           
Flag Coverage Δ
GHA_Ubuntu 98.42% <ø> (ø)
GHA_Windows 98.11% <ø> (ø)
GHA_macOS 98.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368fd4f...41bafd4. Read the comment docs.

@hugovk hugovk merged commit 67e6386 into main Apr 14, 2022
@hugovk hugovk deleted the prep-automerge branch April 14, 2022 14:08
@hugovk hugovk mentioned this pull request Apr 14, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants