Add benchmarks for speedups #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Jun 30, 2023
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
=======================================
Coverage 79.50% 79.50%
=======================================
Files 26 26
Lines 1952 1952
Branches 598 598
=======================================
Hits 1552 1552
Misses 359 359
Partials 41 41 ☔ View full report in Codecov by Sentry. |
rytilahti
reviewed
Jun 30, 2023
Co-authored-by: Teemu R. <[email protected]>
bdraco
commented
Jun 30, 2023
|
moved and adjusted readme |
|
Could you still adjust the README.md of the devtools dir (with the example you had earlier)? |
|
close reopen to restart CI |
sdb9696
added a commit
to sdb9696/python-kasa
that referenced
this pull request
Jul 5, 2023
* Add optional kasa-crypt dependency for speedups (python-kasa#464) If installed, use the optimized protocol encryption procedures implemented as a C extension by kasa-crypt (https://pypi.org/project/kasa-crypt/ * Add fixture for KP405 Smart Dimmer Plug (python-kasa#470) * Add files via upload * Add to KP405 to dimmers, update README --------- Co-authored-by: Teemu Rytilahti <[email protected]> * Add benchmarks for speedups (python-kasa#473) * Add benchmarks for speedups * Update README.md * Update README.md Co-authored-by: Teemu R. <[email protected]> * relo * Update README.md * document benchmark * Update README.md --------- Co-authored-by: Teemu R. <[email protected]> * Release 0.5.2 (python-kasa#475) Besides some small improvements, this release: * Adds optional dependency for for `orjson` and `kasa-crypt` to speed-up protocol handling by an order of magnitude. * Drops Python 3.7 support as it is no longer maintained. [Full Changelog](python-kasa/python-kasa@0.5.1...0.5.2) * Merge --------- Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: xinud190 <[email protected]> Co-authored-by: Teemu Rytilahti <[email protected]>
sdb9696
added a commit
to sdb9696/python-kasa
that referenced
this pull request
Jul 5, 2023
* Initial commit * Update tests and some structure * Update tests and discovery single logic * Add more discovery tests * pre-commit poetry black formatting * Dev1 (#1) * Initial commit * Update tests and some structure * Update tests and discovery single logic * Add more discovery tests * pre-commit poetry black formatting * Latest changes from upstream * Update comments * Add changes from upstream2 (#5) * Add optional kasa-crypt dependency for speedups (python-kasa#464) If installed, use the optimized protocol encryption procedures implemented as a C extension by kasa-crypt (https://pypi.org/project/kasa-crypt/ * Add fixture for KP405 Smart Dimmer Plug (python-kasa#470) * Add files via upload * Add to KP405 to dimmers, update README --------- Co-authored-by: Teemu Rytilahti <[email protected]> * Add benchmarks for speedups (python-kasa#473) * Add benchmarks for speedups * Update README.md * Update README.md Co-authored-by: Teemu R. <[email protected]> * relo * Update README.md * document benchmark * Update README.md --------- Co-authored-by: Teemu R. <[email protected]> * Release 0.5.2 (python-kasa#475) Besides some small improvements, this release: * Adds optional dependency for for `orjson` and `kasa-crypt` to speed-up protocol handling by an order of magnitude. * Drops Python 3.7 support as it is no longer maintained. [Full Changelog](python-kasa/python-kasa@0.5.1...0.5.2) * Merge --------- Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: xinud190 <[email protected]> Co-authored-by: Teemu Rytilahti <[email protected]> * get changes from upstream * Move unauthenticated logic out of unauthenticated device --------- Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: xinud190 <[email protected]> Co-authored-by: Teemu Rytilahti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
[speedups], the protocol overhead is roughly an order of magnitude lower (benchmarks available in bench)This benchmark is from an M2 Mac Pro laptop.
This benchmark is from a Home Assistant Yellow