Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize locations #126

Closed
wants to merge 1 commit into from
Closed

Standardize locations #126

wants to merge 1 commit into from

Conversation

vinayak-mehta
Copy link
Contributor

Hi! 👋

I'm using the 2020 csv here: https://github.com/vinayak-mehta/conrad, so standardized the location column to make it easier to parse.

@vinayak-mehta vinayak-mehta mentioned this pull request Nov 3, 2019
Merged
@vinayak-mehta
Copy link
Contributor Author

vinayak-mehta commented Nov 4, 2019 •
edited
Loading

Should we validate CSVs in PRs (maybe using a GitHub Action) so that some of the fields are standardized (dates, locations, country codes etc.)? We can use @di's vladiate. I can work on it sometime this week.

@vinayak-mehta
Copy link
Contributor Author

@alanderex Can you please review and merge this? 😃

@alanderex
Copy link
Member

alanderex commented Nov 5, 2019 •
edited
Loading

will check

@alanderex
Copy link
Member

Normalized 2020 data in d150f8e @vinayak-mehta

@alanderex alanderex closed this Nov 5, 2019
@vinayak-mehta
Copy link
Contributor Author

Thanks!

@vinayak-mehta vinayak-mehta deleted the patch-1 branch November 5, 2019 10:15
@alanderex
Copy link
Member

Update: in fact now everything should be fine with 91dc4ef

@vinayak-mehta
Copy link
Contributor Author

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinayak-mehta @alanderex @webknjaz