Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.8 and PyPy3.6 on Windows with GitHub Actions #4220

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Nov 20, 2019

Adds Python 3.8 to Windows build matrix on GitHub Actions.
Edit: Also adds PyPy3.6-7.2.0 to Windows build matrix on GitHub Actions.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nulano nulano changed the title Test Python 3.8 on Windows with GitHub Actions Test Python 3.8 and PyPy3.6 on Windows with GitHub Actions Nov 20, 2019
@nulano
Copy link
Contributor Author

nulano commented Nov 20, 2019

I finally managed to get PyPy to build - after comparing traces in a debugger, I discovered that unlike CPython3.6 (which uses distutils._msvccompiler), PyPy uses distutils.msvc9compiler, which requires theMSSdk envar in addition to DISTUTILS_USE_SDK.

Edit: Link to relevant discussion: #4188, #4201

@nulano nulano requested a review from hugovk November 20, 2019 21:28
@hugovk hugovk merged commit bd34b23 into python-pillow:master Nov 21, 2019
@hugovk
Copy link
Member

hugovk commented Nov 21, 2019

Thanks again!

@nulano nulano deleted the gha-win-update branch November 21, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants