Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPy to the Travis build #571

Merged
merged 4 commits into from
Mar 25, 2014
Merged

Add PyPy to the Travis build #571

merged 4 commits into from
Mar 25, 2014

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 25, 2014

See #570

All that was needed was a "sudo apt-get install python-tk" in the .travis.yml.

But perhaps the install should only happen for the PyPy build, what do you think?

And should PyPy be an allowed failure or would you prefer a normal build?

@kmike
Copy link
Contributor

kmike commented Mar 25, 2014

I think that it is a good change, but it still leaves Pillow's detection of Tkinter broken, and masks this issue by installing tkinter. For PyPy users without tkinter Pillow will fail. See travis-ci/travis-ci#1654.

@wiredfool
Copy link
Member

I'm open to changing the try/except in setup.py to check OSError as well. That should fix tk detection on pypy, if I'm reading the travis thread correctly.

@wiredfool
Copy link
Member

It looks like pypy isn't getting the tkinter package on travis. I suspect that it's a combination of site packages only working with py27 (the default python) and the python-tk package installing for that library.

Also, there's one test that's slower than a slug in winter on pypy -- see #484. If we push this to master, we should fix or disable that test.

aclark4life added a commit that referenced this pull request Mar 25, 2014
Add PyPy to the Travis build
@aclark4life aclark4life merged commit eb64609 into python-pillow:master Mar 25, 2014
@aclark4life
Copy link
Member

Thanks

@aclark4life
Copy link
Member

Fixes #570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants