-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added type hints to additional tests #7846
Conversation
The CI is failing for Ubuntu with all versions (except PyPy). For example: ERROR Tests/test_image_fromqimage.py::test_sanity_1 - Failed: fixture function has more than one 'yield':
@pytest.fixture
def test_images() -> Generator[Image.Image, None, None]:
ims = [
hopper(),
Image.open("Tests/images/transparent.png"),
Image.open("Tests/images/7x13.png"),
]
try:
yield from ims
finally:
for im in ims:
im.close()
/home/runner/work/Pillow/Pillow/Tests/test_image_fromqimage.py:21
FAILED Tests/test_image_fromqimage.py::test_sanity_1 - TypeError: 'PpmImageFile' object is not iterable
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 2 failures !!!!!!!!!!!!!!!!!!!!!!!!!!! |
Ok, I've updated the commit so that it passes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -152,12 +152,13 @@ def test_nonstack_dos() -> None: | |||
assert i <= 1, "Non-stack DOS file test failed" | |||
|
|||
|
|||
# for issue #4093 | |||
# for issue #4093s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks. I've created #7855
No description provided.