-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock around usages of imaging memory arenas #8238
Conversation
This is ready to be reviewed more throughly. All tests pass and tsan is happy. |
Out of curiosity, how are you testing with tsan? I don't think we have it in CI (although perhaps we should add it!). |
I added a few very very basic threaded tests, built CPython and Pillow with tsan enabled and then ran the tests. It all takes forever, cause CPython with tsan is very slow, but it works. If your question is how I build Pillow with tsan enabled, it is really easy:
|
If no other reviews or comments, I'll merge this tomorrow. |
Thanks @lysnikolaou! |
Related to #8199.
Did some testing with threads. Thread-sanitizer is also happy after these changes.