Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dev-dependencies resolution from the build #101

Merged
merged 4 commits into from
Oct 22, 2020
Merged

remove dev-dependencies resolution from the build #101

merged 4 commits into from
Oct 22, 2020

Conversation

roxchkplusony
Copy link
Contributor

@roxchkplusony roxchkplusony commented Oct 14, 2020 •
edited by abn
Loading

Relates-to: python-poetry/poetry#2174

  • Added tests for changed code.
  • Updated documentation for changed code.

@roxchkplusony roxchkplusony force-pushed the 2174/remove-dev-from-build branch 2 times, most recently from 675cf9d to e483920 Compare October 14, 2020 20:04
abn
abn requested changes Oct 14, 2020
View reviewed changes
tests/fixtures/project_with_invalid_dev_deps/pyproject.toml Show resolved Hide resolved
poetry/core/masonry/api.py Show resolved Hide resolved
poetry/core/factory.py Outdated Show resolved Hide resolved
tests/test_factory.py Outdated Show resolved Hide resolved
poetry/core/masonry/api.py Show resolved Hide resolved
abn
abn requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have inadvertantly moved tests/json/__init__.py. Additionally, it could be great if we could parametrise the tests reduce some duplication (optional).

Otherwise looks good.

@roxchkplusony
Copy link
Contributor Author

Added back the init.py file I had inadvertently deleted. I don't see a great deduplication opportunity with the two test files, but let me know if your optional becomes mandatory. Otherwise, I hope I can get an approve.

@abn abn merged commit 727907d into python-poetry:master Oct 22, 2020
@roxchkplusony roxchkplusony deleted the 2174/remove-dev-from-build branch October 22, 2020 20:34
This was referenced Nov 19, 2020
Closed
Closed
@orlevii
Copy link

orlevii commented Nov 26, 2020

Any plans to release this fix soon? 🙏

@sdispater sdispater mentioned this pull request Feb 5, 2021
Merged
@neersighted neersighted mentioned this pull request Oct 5, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roxchkplusony @orlevii @abn