Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency markers not being copied in with_constraint() #162

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fix dependency markers not being copied in with_constraint() #162

merged 1 commit into from
Apr 9, 2021

Conversation

sdispater
Copy link
Member

The dependency markers were not copied when using Dependency.with_constraint() causing resolution issues like in python-poetry/poetry#3878

Resolves: python-poetry/poetry#3878

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater requested a review from a team April 9, 2021 09:56
@sdispater sdispater mentioned this pull request Apr 9, 2021
Merged
2 tasks
@abn abn merged commit d3e6073 into master Apr 9, 2021
@abn abn deleted the fix-markers-with-consttraint branch April 9, 2021 15:01
@sdispater sdispater mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot resolve python=^3.4 with httpx
2 participants
@sdispater @abn