Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update test scripts to use install-poetry.py and cleanup release workflow #168

Merged
merged 2 commits into from
Apr 11, 2021

Conversation

abn
Copy link
Member

@abn abn commented Apr 10, 2021

This change also fixes python 3.10 failures.

@abn abn requested a review from a team April 10, 2021 23:11
@abn
Copy link
Member Author

abn commented Apr 10, 2021

THe new 3.10 failures are due to missing setuptools in the project virtual environment. Since new versions of poetry drops pip and setuptools from project environments (python-poetry/poetry#2826), we have an issue with adding it as a development dependency (which is the right fix) in that adding via poetry@master will lead to all existing versions to fail as they mark setuptools and unsafe, leading to resolution errors.

@sdispater I wonder if this makes a good case for pyproject.toml allowing a configuration for min-poetry similar to what tox does.

@kasteph kasteph merged commit 015e05d into python-poetry:master Apr 11, 2021
@abn abn deleted the ci/fix-experimental branch April 11, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants