Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package equality check and repr #53

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

abn
Copy link
Member

@abn abn commented Jul 27, 2020

We need to be a bit more stricter with how we compare packages as prior to this we would check two packages, foo-1.0.0 with source_reference=x and foo-1.0.0 with source_reference=y as the same. Which can lead to some unexpected issues at poetry runtime and incorrect validation in poetry's test suites as well.

@abn abn requested a review from a team July 27, 2020 18:07
@abn abn force-pushed the improve-package-equality branch from 969d3cb to f502500 Compare July 27, 2020 18:15
abn added a commit to abn/poetry that referenced this pull request Jul 27, 2020
Prior to this change, when checking solver results the tests cases
relied on the weaker equality check of the `Package` class. With
python-poetry/poetry-core#53, the check has been made stricter.

This change, while having no functional impact, ensures that once
poetry-core is updated, tests do not fail unexpectedly.
@abn
Copy link
Member Author

abn commented Jul 31, 2020

@sdispater any concerns on this one?

Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@sdispater sdispater merged commit 28848f0 into python-poetry:master Aug 7, 2020
@abn abn deleted the improve-package-equality branch August 7, 2020 09:28
abn added a commit to abn/poetry that referenced this pull request Aug 10, 2020
Prior to this change, when checking solver results the tests cases
relied on the weaker equality check of the `Package` class. With
python-poetry/poetry-core#53, the check has been made stricter.

This change, while having no functional impact, ensures that once
poetry-core is updated, tests do not fail unexpectedly.
abn added a commit to abn/poetry that referenced this pull request Aug 10, 2020
Prior to this change, when checking solver results the tests cases
relied on the weaker equality check of the `Package` class. With
python-poetry/poetry-core#53, the check has been made stricter.

This change, while having no functional impact, ensures that once
poetry-core is updated, tests do not fail unexpectedly.
finswimmer pushed a commit to python-poetry/poetry that referenced this pull request Aug 15, 2020
Prior to this change, when checking solver results the tests cases
relied on the weaker equality check of the `Package` class. With
python-poetry/poetry-core#53, the check has been made stricter.

This change, while having no functional impact, ensures that once
poetry-core is updated, tests do not fail unexpectedly.
@sdispater sdispater mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants