-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate hash function from FileDependency #535
Conversation
Given the way that python-poetry/poetry#7121 is going, this wants to become an MR that deprecates or removes the hash() method on the file dependency |
0ef3768
to
34e0e48
Compare
34e0e48
to
a16859a
Compare
I removed the |
Please don't remove but deprecate it. See poetry-core/src/poetry/core/utils/helpers.py Lines 28 to 34 in 51e625d
In the tests, please add a |
a16859a
to
b3c5bbb
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Okay, added it back with the deprecation warnings. |
This will enable URLDependency to compute the hash for the file at the temporary path. The temporary path should be the path to the downloaded file from
URLDependency.url
.Relates-to: python-poetry/poetry#7121