utils/env: ensure user directories are created

python-poetry · Oct 23, 2020 · 34662ba · 34662ba
1 parent d660b51
commit 34662ba
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/poetry/masonry/builders/editable.py b/poetry/masonry/builders/editable.py
@@ -131,7 +131,7 @@ def _add_scripts(self):
         entry_points = self.convert_entry_points()
 
         for scripts_path in self._env.script_dirs:
-            if is_dir_writable(scripts_path):
+            if is_dir_writable(path=scripts_path, create=True):
                 break
         else:
             self._io.error_line(

diff --git a/poetry/utils/env.py b/poetry/utils/env.py
@@ -170,7 +170,7 @@ def writable_candidates(self):  # type: () -> List[Path]
 
         self._writable_candidates = []
         for candidate in self._candidates:
-            if not is_dir_writable(candidate):
+            if not is_dir_writable(path=candidate, create=True):
                 continue
             self._writable_candidates.append(candidate)
 

diff --git a/tests/utils/test_env_site.py b/tests/utils/test_env_site.py
@@ -5,7 +5,9 @@
 from poetry.utils.env import SitePackages
 
 
-def test_env_site_simple(tmp_dir):
+def test_env_site_simple(tmp_dir, mocker):
+    # emulate permission error when creating directory
+    mocker.patch("poetry.utils._compat.Path.mkdir", side_effect=OSError())
     site_packages = SitePackages(Path("/non-existent"), fallbacks=[Path(tmp_dir)])
     candidates = site_packages.make_candidates(Path("hello.txt"), writable_only=True)
     hello = Path(tmp_dir) / "hello.txt"