-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generated setup.py is incomplete/incorrect for multiple packages elements #2354
Closed
2 tasks done
Comments
Can I work on this issue @sdispater ? |
@gwuah Yes, go ahead. If you need any guidance, feel free to ask. |
abn
added
kind/bug
Something isn't working as expected
area/core
Related to the poetry-core library
status/triage
This issue needs to be triaged
labels
Apr 26, 2020
2 tasks
jaharkes
added a commit
to jaharkes/poetry-core
that referenced
this issue
Nov 16, 2020
When we define multiple packages from different source locations, Poetry currently only uses the last specified from=. This patch adds explicit paths to package_dir for any additional packages. This fixes python-poetry/poetry#1811, python-poetry/poetry#2354 And possibly python-poetry/poetry#2450
jaharkes
added a commit
to jaharkes/poetry-core
that referenced
this issue
Nov 16, 2020
When we define multiple packages from different source locations, Poetry currently only uses the last specified from=. This patch adds explicit paths to package_dir for any additional packages. This fixes python-poetry/poetry#1811 python-poetry/poetry#2354 And possibly python-poetry/poetry#2450
jaharkes
added a commit
to jaharkes/poetry-core
that referenced
this issue
Nov 16, 2020
When we define multiple packages from different source locations, Poetry currently only uses the last specified from= location. This patch adds explicit paths to package_dir for additional packages. This fixes python-poetry/poetry#1811, fixes python-poetry/poetry#2354, and possibly even python-poetry/poetry#2450.
1 task
jaharkes
added a commit
to jaharkes/poetry-core
that referenced
this issue
Jun 3, 2021
When we define multiple packages from different source locations, Poetry currently only uses the last specified from= location. This patch adds explicit paths to package_dir for additional packages. This fixes python-poetry/poetry#1811, fixes python-poetry/poetry#2354, and possibly even python-poetry/poetry#2450.
jaharkes
added a commit
to jaharkes/poetry-core
that referenced
this issue
Nov 10, 2021
When we define multiple packages from different source locations, Poetry currently only uses the last specified from= location. This patch adds explicit paths to package_dir for additional packages. This fixes python-poetry/poetry#1811, fixes python-poetry/poetry#2354, and possibly even python-poetry/poetry#2450.
neersighted
pushed a commit
to python-poetry/poetry-core
that referenced
this issue
Nov 10, 2021
* Fix for including modules from different locations When we define multiple packages from different source locations, Poetry currently only uses the last specified from= location. This patch adds explicit paths to package_dir for additional packages. This fixes python-poetry/poetry#1811, fixes python-poetry/poetry#2354, and possibly even python-poetry/poetry#2450. * Test the fix for including modules from different locations When we try to include moduleA from libA and moduleB from libB then package_dir in the generated setup.py must to contain either one or both `"moduleA": "libA/moduleA"` or `"moduleB": "libB/moduleB"` so we are able to find both modules when building the source dist. `ns["package_dir"].keys() == {"", "module_b"}` should always be true, so we don't have to test for module_a in `ns["package_dir"]`.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I am on the latest Poetry version.
I have searched the issues of this repo and believe that this is not a duplicate.
OS version and name: macOS 12.14.3
Poetry version: 0.12.11
Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/delphyne/554c9274f69a290e8bcd0ccfcbfb0b1c
Issue
When using the packages list to include overlapping packages, the generated setup.py in the sdist is incomplete and incorrect. The wheel generated, however, is correct and complete.
for example: the following incomplete pyproject.toml (the complete example is linked above):
packages should be:
package_dir should probably be:
The text was updated successfully, but these errors were encountered: