Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-C during poetry add doesn't revert changes #2933

Closed
Vozf opened this issue Sep 18, 2020 · 2 comments · Fixed by #3233
Closed

Ctrl-C during poetry add doesn't revert changes #2933

Vozf opened this issue Sep 18, 2020 · 2 comments · Fixed by #3233
Labels
area/cli Related to the command line area/error-handling Bad error messages/insufficient error handling kind/bug Something isn't working as expected

Comments

@Vozf
Copy link

Vozf commented Sep 18, 2020

If I interrupt poetry add with ctrl-C it still adds dependency to pyproject.yaml. This should be either reverted or be done in the end of installation
@Vozf Vozf added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Sep 18, 2020
@finswimmer
Copy link
Member

Hello @Vozf,

this one is similar to yours: #381

fin swimmer

@finswimmer finswimmer added area/cli Related to the command line area/error-handling Bad error messages/insufficient error handling labels Sep 21, 2020
@estyxx estyxx mentioned this issue Oct 17, 2020
Merged
2 tasks
@abn abn closed this as completed in #3233 Oct 19, 2020
abn pushed a commit that referenced this issue Oct 19, 2020
@estyxx
add: fix revert for dry-run and interrupts
a66033b 
This change correctly reverts pyproject.toml changes for dry runs as 
well as keyboard interrupts.

Resolves: #2933 #318
sdispater pushed a commit that referenced this issue Jan 30, 2021
@estyxx @sdispater
add: fix revert for dry-run and interrupts
40fc496 
This change correctly reverts pyproject.toml changes for dry runs as 
well as keyboard interrupts.

Resolves: #2933 #318
finswimmer pushed a commit that referenced this issue Jan 30, 2021
@estyxx @finswimmer
add: fix revert for dry-run and interrupts
6d957e6 
This change correctly reverts pyproject.toml changes for dry runs as 
well as keyboard interrupts.

Resolves: #2933 #318
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/cli Related to the command line area/error-handling Bad error messages/insufficient error handling kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add command catch KeyboardInterrupt and restore original_content (2933, 318) estyxx/poetry
3 participants
@abn @finswimmer @Vozf