Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry attempts to install all VCS deps as editable, even when develop = false. #3263

Closed
3 tasks done
triptec opened this issue Oct 21, 2020 · 3 comments
Closed
3 tasks done
Labels
kind/bug Something isn't working as expected

Comments

@triptec
Copy link

triptec commented Oct 21, 2020

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: Ubuntu 20.04
  • Poetry version: 1.1.3

Issue

Hello, I'm having a hard time adding a git dependency and even though i set develop = false, the command to pip install has a "-e" and then fails with ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /usr/local/src/fastapi (A "pyproject.toml" file was found, but editable mode currently requires a setup.py based build.)

@triptec triptec added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Oct 21, 2020
abn added a commit to abn/poetry that referenced this issue Oct 21, 2020
@abn
Copy link
Member

abn commented Oct 21, 2020

Can you please try the fix at #3264.

Using pipx

pipx install --suffix=@3264 'poetry @ git+https://github.com/python-poetry/poetry.git@refs/pull/3264/head'

Using a container (podman | docker)

podman run --rm -i --entrypoint bash python:3.8 <<EOF
set -xe
python -m pip install -q git+https://github.com/python-poetry/poetry.git@refs/pull/3264/head
install -d foobar
pushd foobar
cat > pyproject.toml <<TOML
[tool.poetry]
name = "foobar"
version = "0.1.0"
description = ""
authors = ["Your Name <[email protected]>"]

[tool.poetry.dependencies]
python = "^3.8"
fastapi = {git = "https://github.com/tiangolo/fastapi.git", develop = false}

[tool.poetry.dev-dependencies]

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"
TOML
poetry install
EOF

@triptec
Copy link
Author

triptec commented Oct 22, 2020

I’ll give it a try later today

finswimmer pushed a commit that referenced this issue Oct 22, 2020
abn added a commit to abn/poetry that referenced this issue Oct 23, 2020
@abn abn closed this as completed in 7c728f0 Oct 23, 2020
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants