When keyring is disabled, poetry tries to use it anyways. #5250

lakinwecker · 2022-02-28T21:30:11Z

I am on the latest Poetry version.
I have searched the issues of this repo and believe that this is not a duplicate.
If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Arch linux up to date:
1.1.13:
Link of a Gist with the contents of your pyproject.toml file: pyproject.toml

Issue

If you disable keyring via it's recommended route: https://github.com/jaraco/keyring#disabling-keyring you end up with a "null" keyring being used. This is a useless keyring, but poetry continues to try and use it regardless. poetry should treat it the same as if keyring was unavailable.

The text was updated successfully, but these errors were encountered:

lakinwecker · 2022-02-28T21:32:38Z

To be clear, when it fails this way, it fails to do things like it doesn't try and use the environment variable. It just silently ignores it.

tyler-8 · 2022-03-10T18:05:31Z

To be clear, when it fails this way, it fails to do things like it doesn't try and use the environment variable. It just silently ignores it.

This is a key symptom. I've been very confused as to why my correctly set environment variables for username/password of a private repo are not working. It wasn't until I disabled the keyring (as apparently I'd configured poetry to use it in the past) that I realized that truly the envars were being bypassed. Instead I get prompted for the password when doing poetry publish -r myrepo.

# envars
POETRY_HTTP_BASIC_MYREPO_USERNAME=someuser
POETRY_HTTP_BASIC_MYREPO_PASSWORD=password

# poetry config --list

repositories.myrepo.url = "https://internalpypi.domain.com/pypi"

kadler · 2022-03-14T19:13:10Z

I ran in to this same issue today. Looks like a similar check like this needs to be made for "null":

https://github.com/python-poetry/poetry/blob/master/src/poetry/utils/password_manager.py#L100-L102

kadler · 2022-03-14T19:16:26Z

As a workaround, the "fail" backend can be used: export PYTHON_KEYRING_BACKEND=keyring.backends.fail.Keyring

lakinwecker · 2022-03-15T15:10:44Z

I ran in to this same issue today. Looks like a similar check like this needs to be made for "null":

https://github.com/python-poetry/poetry/blob/master/src/poetry/utils/password_manager.py#L100-L102

Yes, that's what the associated pull request does. 👍 Just waiting on me to have the time to get the unit tests done and I don't know when that will happen.

kadler · 2022-03-15T16:21:02Z

Oh sorry, I didn't see there was a PR already. Nice!

epogrebnyak · 2022-04-24T12:01:02Z

As a workaround, the "fail" backend can be used: export PYTHON_KEYRING_BACKEND=keyring.backends.fail.Keyring

This is genius, helped so much, thank you.

callamd · 2023-05-03T12:59:08Z

2023 and this issue still exists and is not fixed. :)

lakinwecker · 2023-05-03T13:15:08Z

This issue was fixed with the #5251 and released sometime thereafter. I haven't run into the issue since that point. If you're running into something similar can you double check that you're using a recent enough version so that it includes the fix and if so, please submit details of how to reproduce it, rather than just claiming it still exists?

maxbachmann · 2023-05-13T17:28:01Z

I am running into this with 1.4.2 again as well. I just tried to run poetry lock in the cleo repository.

lakinwecker · 2023-05-15T17:32:30Z

I can't reproduce it: https://gist.github.com/lakinwecker/e85279c2fece8bec211c3608567c4162

Do you have an environment variable for PYTHON_KEYRING_BACKEND set? I don't


cleo on  main is 📦 v2.1.0.dev0 via 🐍 v3.11.3 (cleo-py3.11) 
!->

lakinwecker · 2023-05-15T17:33:50Z

Even with the keyring set, I can't reproduce it.

aldum · 2023-05-20T09:14:45Z

Question: why is it trying to access a keyring when installing dependencies?

ralbertazzi · 2023-05-20T09:42:52Z

#1917

I don't really need it at the moment and there is a bug with poetry. python-poetry/poetry#5250 python-poetry/poetry#1917

rdbisme · 2023-10-10T18:18:47Z

Question: why is it trying to access a keyring when installing dependencies?

Because sometimes you might want to access dependencies on an authenticated custom pypi registry?

maciej-gol · 2023-11-06T10:37:00Z

Question: why is it trying to access a keyring when installing dependencies?

Because sometimes you might want to access dependencies on an authenticated custom pypi registry?

It should be clear which dependencies it accesses the keyring for, though. Having a generic prompt to access my keyring by a package manager knowing that I don't use custom pypi registry triggers my safety bells.

kierke-gaard · 2023-11-27T14:56:28Z

Same problem on wsl2. This has helped (thanks for the advise):

export PYTHON_KEYRING_BACKEND=keyring.backends.fail.Keyring

gbrandt1 · 2023-12-03T13:53:18Z

still present in 1.7.1 :-(

codethief · 2024-02-20T19:49:01Z

I just ran into this again and, once more, it took me a while to figure this out, since poetry add -vvv <package> just froze and didn't output anything useful. sigh

Can we please at least re-open this ticket and acknowledge this is an issue that needs fixing?

radoering · 2024-02-21T05:00:49Z

There is #8623 and #8761. Do you think we need a third issue?

And there is #8910 (which will be included in 1.8). Apart from introducing a config setting to disable keyring, it refactored keyring access and thereby fixed some bugs.

maciej-gol · 2024-02-21T09:00:25Z

@radoering From my POV, this doesn't address my concerns, as I still believe keyring should be disabled by default and opt-in for users that actually need it. That solution no different than putting export PYTHON_KEYRING_BACKEND=keyring.backends.fail.Keyring into my .bashrc. But its a step into good direction, nonetheless.

ManBearPigg · 2024-02-27T23:46:18Z

There is #8623 and #8761. Do you think we need a third issue?

Prob because it breaks the whole project and the obscure fix is hard to find. I know it's free software I'm just saying why

callamd · 2024-02-29T11:59:31Z

Let me help ya'll out with some pseudocode ``` if need_keyring: ask_for_keyring() ```

…

On Wed, 21 Feb 2024 at 09:00, Maciej Gol ***@***.***> wrote: @radoering <https://github.com/radoering> From my POV, this doesn't address my concerns, as I still believe keyring should be disabled by default and opt-in for users that *actually need* it. That solution no different than putting export PYTHON_KEYRING_BACKEND=keyring.backends.fail.Keyring into my .bashrc. But its a step into good direction, nonetheless. — Reply to this email directly, view it on GitHub <#5250 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMWNEEDVH3UEWI3AQYB7TLYUWZTNAVCNFSM5PSHIM62U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJVGYYTOOJRGE4Q> . You are receiving this because you commented.Message ID: ***@***.***>

maciej-gol · 2024-03-01T13:40:46Z

@cal97g nice try, 2/10. Missing tests.

alanwilter · 2024-03-20T14:47:33Z

Why is this issue closed? Spent two days and two developers to figure this out, using v1.8.2.

poetry could be much smarter here. Could at least warn about it. This is another reason why we considering hatch again.

radoering · 2024-03-20T15:39:03Z

It's closed because the original issue has been resolved in #5251.
(Poetry now respects PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring.)

As already mentioned, there are at least two open issues, which fit better for people still experiencing issues with keyring: #8623 and #8761

If you have useful information please comment on these issues or open a new issue if you think that your issue is not covered by them.

lakinwecker added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Feb 28, 2022

lakinwecker mentioned this issue Feb 28, 2022

when "disabled", keyring uses a "null" keyring and should be unavaila… #5251

Merged

2 tasks

radoering closed this as completed in #5251 Apr 12, 2022

mkniewallner removed the status/triage This issue needs to be triaged label Jun 11, 2022

zyv mentioned this issue Oct 19, 2022

Keyring errors during non-publishing operations #1917

Closed

a16su added a commit to a16su/registry_client that referenced this issue Oct 29, 2022

issue:python-poetry/poetry#5250

0b1363d

a16su added a commit to a16su/registry_client that referenced this issue Oct 29, 2022

issue:python-poetry/poetry#5250

8d36718

prassanna-ravishankar mentioned this issue Mar 16, 2023

Poetry's keyring bug causes Clearml remote execution to fail allegroai/clearml-agent#146

Open

Nebucatnetzer added a commit to Nebucatnetzer/network_inventory that referenced this issue Jun 25, 2023

Disable the keyring

8665808

I don't really need it at the moment and there is a bug with poetry. python-poetry/poetry#5250 python-poetry/poetry#1917

o-smirnov mentioned this issue Jun 28, 2023

poetry install fails with "Failed to create the collection: Prompt dismissed.." caracal-pipeline/stimela#160

Closed

python-poetry locked as resolved and limited conversation to collaborators Mar 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When keyring is disabled, poetry tries to use it anyways. #5250

When keyring is disabled, poetry tries to use it anyways. #5250

lakinwecker commented Feb 28, 2022

lakinwecker commented Feb 28, 2022

tyler-8 commented Mar 10, 2022

kadler commented Mar 14, 2022

kadler commented Mar 14, 2022

lakinwecker commented Mar 15, 2022

kadler commented Mar 15, 2022

epogrebnyak commented Apr 24, 2022

callamd commented May 3, 2023

lakinwecker commented May 3, 2023

maxbachmann commented May 13, 2023

lakinwecker commented May 15, 2023 •

edited

Loading

lakinwecker commented May 15, 2023

aldum commented May 20, 2023

ralbertazzi commented May 20, 2023

rdbisme commented Oct 10, 2023

maciej-gol commented Nov 6, 2023

kierke-gaard commented Nov 27, 2023

gbrandt1 commented Dec 3, 2023

codethief commented Feb 20, 2024 •

edited

Loading

radoering commented Feb 21, 2024

maciej-gol commented Feb 21, 2024

ManBearPigg commented Feb 27, 2024

callamd commented Feb 29, 2024 via email •

edited

Loading

maciej-gol commented Mar 1, 2024

alanwilter commented Mar 20, 2024 •

edited

Loading

radoering commented Mar 20, 2024

When keyring is disabled, poetry tries to use it anyways. #5250

When keyring is disabled, poetry tries to use it anyways. #5250

Comments

lakinwecker commented Feb 28, 2022

Issue

lakinwecker commented Feb 28, 2022

tyler-8 commented Mar 10, 2022

kadler commented Mar 14, 2022

kadler commented Mar 14, 2022

lakinwecker commented Mar 15, 2022

kadler commented Mar 15, 2022

epogrebnyak commented Apr 24, 2022

callamd commented May 3, 2023

lakinwecker commented May 3, 2023

maxbachmann commented May 13, 2023

lakinwecker commented May 15, 2023 • edited Loading

lakinwecker commented May 15, 2023

aldum commented May 20, 2023

ralbertazzi commented May 20, 2023

rdbisme commented Oct 10, 2023

maciej-gol commented Nov 6, 2023

kierke-gaard commented Nov 27, 2023

gbrandt1 commented Dec 3, 2023

codethief commented Feb 20, 2024 • edited Loading

radoering commented Feb 21, 2024

maciej-gol commented Feb 21, 2024

ManBearPigg commented Feb 27, 2024

callamd commented Feb 29, 2024 via email • edited Loading

maciej-gol commented Mar 1, 2024

alanwilter commented Mar 20, 2024 • edited Loading

radoering commented Mar 20, 2024

lakinwecker commented May 15, 2023 •

edited

Loading

codethief commented Feb 20, 2024 •

edited

Loading

callamd commented Feb 29, 2024 via email •

edited

Loading

alanwilter commented Mar 20, 2024 •

edited

Loading