Multiple fixes for repository http authentication #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that we use configured repositories to detect credentials instead of `http-basic.` Resolves: python-poetry#2799 Co-authored-by: Fredrik Bergroth <[email protected]>
This change unifies the use of authenticator for legacy repositories. This ensures that we retrieve the correct credentials in all cases. Relates-to: python-poetry#2799 python-poetry#2988
2 tasks
sdispater
approved these changes
Sep 28, 2020
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factory: merge sources into config repositories
This ensures that we use credentials when performing searches and adds correctly.
authenticator: use configured repositories
This change ensures that we use configured repositories to detect
credentials instead of
http-basic.repositories: use authenticator for legacy repos
This change unifies the use of authenticator for legacy repositories.
This ensures that we retrieve the correct credentials in all cases.
Resolves: #2799 #2988
Closes: #2955