Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep610: handle pure/plat lib differences cleanly #3891

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

abn
Copy link
Member

@abn abn commented Apr 7, 2021

No description provided.

@abn abn requested a review from a team April 7, 2021 21:11
@abn abn marked this pull request as draft April 7, 2021 21:50
@abn abn force-pushed the fix/platlib-direct-url branch 4 times, most recently from bd267c8 to f6a9628 Compare April 7, 2021 23:09
@abn
Copy link
Member Author

abn commented Apr 7, 2021

Python 3.10 failures are due to the 3.10.alpha.7 build. Similar failure at https://github.com/python-poetry/poetry/pull/3885/checks?check_run_id=2292090242#step:11:20.

@abn abn marked this pull request as ready for review April 7, 2021 23:10
kasteph
kasteph previously approved these changes Apr 8, 2021
Copy link
Member

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is a non-blocker.

poetry/installation/executor.py Outdated Show resolved Hide resolved
@abn abn merged commit 4835c59 into python-poetry:master Apr 8, 2021
@abn abn deleted the fix/platlib-direct-url branch April 8, 2021 19:32
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants