Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested local dependencies (#3368) #4320

Closed
wants to merge 1 commit into from
Closed

Fix nested local dependencies (#3368) #4320

wants to merge 1 commit into from

Conversation

lucasvieirasilva
Copy link

This PR resolves the issue when the project has more than 2 levels of path dependencies.

/lib
    /pkg1
        pyproject.toml
    /pkg2
        pyproject.toml
/apps
    /app1
        pyproject.toml

Solution

Check when the source package is directory to use the property source_url as root_dir instead of using the self._lock.path.parent if the source package is not a directory type the installation process continues normally.

That makes poetry-core resolve correctly the full path property.

Pull Request Check List

Resolves: #3368

  • Added tests for changed code.
  • Updated documentation for changed code.

@lucasvieirasilva
Copy link
Author

Duplicated fix #4246

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry install fails for nested local dependencies and develop = false
1 participant