Fix #3139 #4448
Closed
Fix #3139 #4448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
requested changes
Nov 15, 2021
| @@ -512,6 +513,12 @@ def _filter_operations( | |||
| package = op.package | |||
|
|
|||
| if op.job_type == "uninstall": | |||
There was a problem hiding this comment.
Let's DRY this up a bit. Something like:
if not self._create_virtualenv and isinstance(op, (Update, Uninstall)):
op.skip(f"Virtualenv creation disabled (during {op.job_type})")
continue
|
I would also like some regression tests to validate this change -- it looks like there are reproduction instructions at the linked issue. |
|
This PR targets closed issue and the |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #3139